tests clean up plugins

block · Nov 4, 2024 · 614d5e6 · 614d5e6
1 parent 5c54835
commit 614d5e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/buildengine/engine_test.go b/internal/buildengine/engine_test.go
@@ -16,7 +16,8 @@ import (
 )
 
 func TestGraph(t *testing.T) {
-	ctx := log.ContextWithNewDefaultLogger(context.Background())
+	ctx, cancel := context.WithCancel(log.ContextWithNewDefaultLogger(context.Background()))
+	t.Cleanup(cancel)
 
 	bindURL, err := url.Parse("http://127.0.0.1:8893")
 	assert.NoError(t, err)

diff --git a/jvm-runtime/plugin/common/java_plugin_test.go b/jvm-runtime/plugin/common/java_plugin_test.go
@@ -75,6 +75,9 @@ func TestJavaConfigDefaults(t *testing.T) {
 			assert.NoError(t, err)
 			plugin, err := languageplugin.New(ctx, allocator, "java", "test")
 			assert.NoError(t, err)
+			t.Cleanup(func() {
+				plugin.Kill()
+			})
 
 			defaults, err := plugin.ModuleConfigDefaults(ctx, dir)
 			assert.NoError(t, err)