fix: ftltest.Call always allows direct initial verb #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
force-pushed
the
worstell/20241010-ftltest-allow-first-module-call
branch
2 times, most recently
from
9b38426 to
d370dee
Compare
when using ftltest.Call, you don't need to mock the verb directly invoked. only downstream verbs must be mocked (or overridden by setting WithCallsAllowedWithinModule globally) fixes #2984
worstell
force-pushed
the
worstell/20241010-ftltest-allow-first-module-call
branch
from
b0129a4 to
53ff74c
Compare
worstell
deleted the
worstell/20241010-ftltest-allow-first-module-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using ftltest.Call, you don't need to mock the verb directly invoked. only downstream verbs must be mocked (or overridden by setting WithCallsAllowedWithinModule globally)
https://sq-tbd.slack.com/archives/C04PEQERFM0/p1727995042643089
fixes #2984