Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove event field that is always true #3920

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: remove event field that is always true #3920

merged 1 commit into from
Jan 7, 2025
+2 −17

Conversation

jvmakine
Copy link
Contributor

@jvmakine jvmakine commented Jan 7, 2025 •
edited
Loading

Can only be true because of

if !resp.ModuleRemoved {
  return nil
}

guard

@jvmakine jvmakine requested a review from alecthomas as a code owner January 7, 2025 04:53
@alecthomas alecthomas mentioned this pull request Jan 7, 2025
Open
@jvmakine jvmakine force-pushed the juho/refactoring-4 branch from 40e7958 to abc08c6 Compare January 7, 2025 04:56
@jvmakine jvmakine force-pushed the juho/refactoring-4 branch from abc08c6 to 5dc64f8 Compare January 7, 2025 05:03
@jvmakine jvmakine enabled auto-merge (squash) January 7, 2025 05:10
@jvmakine jvmakine merged commit 1b3cb6b into main Jan 7, 2025
61 checks passed
@jvmakine jvmakine deleted the juho/refactoring-4 branch January 7, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvmakine