fix: minor types fix #4152
Closed
fix: minor types fix #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
stuartwdouglas/minor-docs
branch
from
915014a to
95cc7ca
Compare
alecthomas
reviewed
Jan 22, 2025
docs/content/docs/reference/types.md
Outdated
| | FTL | Go | Kotlin | Java | | ||
| |:-------------------|:-----------------------------|:-----------------------------|:-----------------------------| | ||
| | `Int` | `int` | `Long` | `long` | | ||
| | `optional[Int]` | `ftl.Optional[int]` | `Long?` | `Long` | |
There was a problem hiding this comment.
FYI FTL represents optional with a ?, exactly like Kotlin.
I think given that 99% of these optionals are uniform, except for Java, maybe it's better to just call out how Java is different in the "Optional" section?
There was a problem hiding this comment.
Maybe a new column instead? Java (optional)
There was a problem hiding this comment.
I have updated the table, and added some additional notes.
stuartwdouglas
force-pushed
the
stuartwdouglas/minor-docs
branch
from
95cc7ca to
69b4ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.