Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifei/configure key chain #389

Open
wants to merge 3 commits into
base: v1.0
Choose a base branch
from
Open

Conversation

lifeizhou-ap
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap commented Dec 3, 2024

What

  • Goose configure

    • When environment variable for the key does not exist, user should add the key in the keychain
    • When environment variable for the key exists, user is asked to whether to add the key in the keychain. They can opt this out
  • Goose session

    • When profile does not exist, exit with the user message to use "goose configure"
    • When key does not exist in the keychain or there is no environment variable, exit with the user message to use "goose configure"

**Screenshots

  1. Configure when key does not found in environment variable or keyring
no_env_no_key_ring
  1. Configure when key has been in keyring, and the user does not update
no_env_has_key_ring_not_update
  1. Configure when key has been in keyring, and the user does not update
no_evn_has_key_ring_update
  1. Configure when key only appears in environment variable, and ask customer to add it in the keyring. Customer opted out
has_env_no_key_ring_no_set
  1. Configure when key only appears in environment variable, and ask customer to add it in the keyring. Customer added it in the keyring
has_env_no_key_ring_set
  1. Start session when profile does not exists. Exit
session_exit_with_no_profile
  1. Start session when key does not exists. Exit
session_exit_with_no_key

Copy link

github-actions bot commented Dec 3, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Lifei/configure key chain". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@lifeizhou-ap lifeizhou-ap changed the base branch from main to v1.0 December 3, 2024 16:13
@lifeizhou-ap lifeizhou-ap marked this pull request as ready for review December 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant