Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature [ui]: add logging in renderer #391

Draft
wants to merge 3 commits into
base: v1.0
Choose a base branch
from
Draft

feature [ui]: add logging in renderer #391

wants to merge 3 commits into from

Conversation

wendytang
Copy link
Collaborator

@wendytang wendytang commented Dec 3, 2024 •
edited
Loading

Datadog dashboard here

image

@wendytang wendytang changed the title add loggins feature [ui]: add logging in renderer Dec 3, 2024
@wendytang wendytang marked this pull request as ready for review December 3, 2024 21:19
michaelneale
michaelneale requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be per bundle made, not in open source (don't want open source coupled to datadog nor a specific client id)

@wendytang wendytang marked this pull request as draft December 3, 2024 22:09
@michaelneale
Copy link
Collaborator

@wendytang I think needs some electron specifics: DataDog/browser-sdk#2196

also - I would consider using something like bundle.py approach to patch it in per build in a release repo - so can move this there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelneale michaelneale michaelneale requested changes

@alexhancock alexhancock Awaiting requested review from alexhancock

@baxen baxen Awaiting requested review from baxen

@jsibbison-square jsibbison-square Awaiting requested review from jsibbison-square

@lifeizhou-ap lifeizhou-ap Awaiting requested review from lifeizhou-ap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendytang @michaelneale