Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade composer version #157

Merged
merged 4 commits into from
May 15, 2023
Merged

Upgrade composer version #157

merged 4 commits into from
May 15, 2023

Conversation

charlielewisme
Copy link
Collaborator

@charlielewisme charlielewisme commented May 10, 2023

  • Update dependencies to match package list published by GCP
  • Add protobuf==3.20.0 to requirements_local.txt since I noticed pip spending a long time trying out various versions to reduce conflicts
  • Update non-Composer packages to latest versions
  • Except black==22.12.0, which is last version that meets google-cloud-bigquery==2.34.4 requirement for packaging<22.0dev
  • And, mostly importantly, web3==5.31.0
    • web3==6.0.0 depends on protobuf>=4.21.6, google-cloud-bigquery==2.34.4 depends on protobuf<4.0.0dev
    • web3>=5.31.1,<6 depends on protobuf==3.19.5
    • OTOH web3>=5.31.0 depends on protobuf>=3.10.0,<4 which suits our needs better
  • This update to web3 obviously requires some alterations to codebase, I followed ethereum-etl for guidance here.
  • Update schedule_interval -> schedule
  • Update operator / hook syntax (DummyOperator -> EmptyOperator)

Related PRs:
blockchain-etl/ethereum-etl#339
blockchain-etl/ethereum-etl#371

  - update imports from web3.utils
  - update middleware_slack -> middleware_onion
  - update web3 calls traceBlock -> trace_block etc.
  - ignore new ContractLogicError raised by invalid tokens
  - add extra eth_chainId_.json response from updated web3 token calls
@charlielewisme charlielewisme marked this pull request as ready for review May 11, 2023 15:17
@charlielewisme
Copy link
Collaborator Author

charlielewisme commented May 11, 2023

Do not merge until Monday. Deployment of new Composer environment requires manual interventions and monitoring.

@charlielewisme charlielewisme merged commit 28c2e53 into main May 15, 2023
@charlielewisme charlielewisme deleted the upgrade-composer-version branch May 15, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants