Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#10multi attest #5

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Feat#10multi attest #5

merged 5 commits into from
Nov 7, 2024

Conversation

LeonardoVieira1630
Copy link
Member

it closes the #10

@LeonardoVieira1630 LeonardoVieira1630 added the enhancement New feature or request label Oct 31, 2024
@LeonardoVieira1630 LeonardoVieira1630 self-assigned this Oct 31, 2024
Copy link

@RafaDSan RafaDSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Léo!

@@ -2,7 +2,7 @@

pragma solidity ^0.8.0;

import { Attestation } from "../Common.sol";
import { Attestation, MultiAttestationRequest } from "../Common.sol";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the MultiAttestationRequest struct being used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch bro. I have modified the multiAttest to not depends on it!

@LeonardoVieira1630 LeonardoVieira1630 merged commit 37bc13e into main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants