fix: keystone dep breaks yarn 4 installation #2322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you try to use web3-onboard with yarn v4 (although I think the problem will be there with yarn v2 and v3) it fails with: YN0001: │ Error: @keystonehq/eth-keyring@^0.14.00.3 isn't supported by any available resolver
First install is ok, but if you run the install again you’ll get the above. 0.14.00.3 is apparently not a valid range and the only way to get this fixed is to fix the dependency. Yarn v1 resolves 0.14.00.3 to 0.14.4 and that is the version I’ve set here.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)