-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/not changing the switched chain id in in app browser #288
Merged
q20274982
merged 6 commits into
develop
from
fix/not-changing-the-switched-chain-id-in-in-app-browser
Nov 2, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2ebc5c6
fix: fix switchableNetwork not init error
q20274982 718c862
fix: enable existSDK support event
q20274982 552bf3e
fix: using wallet_disconnect replace disconnect fn
q20274982 868c971
refactor: remove existedSDK redundant code
q20274982 44c70c7
refactor: enhance existedSDK check condition
q20274982 51a3a80
feat: enable aptos's existedSDK event
q20274982 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the condition
if (this.existedSDK?.isBlocto)
is more concise and achieves the same effect asconst existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto)
. If there are no issues, I'll replaceconst existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto)
with it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced all the
const existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto)
withif (this.existedSDK?.isBlocto)
in this commit refactor: enhance existedSDK check condition