Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #409

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: fix typos #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1610da0
fix typos
omahs Apr 5, 2024
f0c275e
fix typos
omahs Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Thanks for showing interest to contribute to Blocto JavaScript SDK, you rock!

## When it comes to open source, there are different ways you can contribute, all of which are valuable. Here's a few guidelines that should help you as you prepare your contribution.
## When it comes to open source, there are different ways you can contribute, all of which are valuable. Here are a few guidelines that should help you as you prepare your contribution.

## Setup the Project

Expand Down Expand Up @@ -56,14 +56,14 @@ https://www.conventionalcommits.org/ or check out the

### Creating a Pull Request

You are welcome to create a pull reuqest against the `develop` branch. The beta release channel goes here. When it's stable, we will pack it all and release in stable channel.
You are welcome to create a pull request against the `develop` branch. The beta release channel goes here. When it's stable, we will pack it all and release in stable channel.

Before creating a PR

1. Make sure your branch is up to date with the `develop` branch
2. On the `root` folder, run `yarn`
3. On the `root` folder, run `yarn build`
4. If a pull request created needs to bump a package version, please see [Changesets](#Changesets) part and add a changesets.
4. If a pull request created needs to bump a package version, please see [Changesets](#Changesets) part and add a changeset.

If everything passes, you should be able to create a PR.

Expand All @@ -77,4 +77,4 @@ If a pull request created needs to bump a package version, please follow those s
2. Under `.changeset/` you will notice a new markdown file (its name is randomly generated), with the change-type and summary.
3. Push the file along with the rest of the changes

Once your PR will be merged, our Github action will create a new PR with that generated changelog for us to merge, once the generated PR is merged a new version will be published to npm.
Once your PR is merged, our Github action will create a new PR with that generated changelog for us to merge, once the generated PR is merged a new version will be published to npm.
4 changes: 2 additions & 2 deletions packages/blocto-sdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ Use Blocto SDK in your dApp to provide excellent user experience!
- Send transactions
- ... and a lot more
- Seamless onboarding experience
Users can sign up easily with email and start exploring you dApp in seconds.
Users can sign up easily with email and start exploring your dApp in seconds.
- Fee subsidization
You have the option to pay transaction fee for your users and provide a better experience. In that case, we will generate daily fee reports for you to review.
- Integrated payment
Get paid easily with our payment APIs. Users can pay easily with credit cards or other crypto currencies like Bitcoin, Ethereum, Tron, USDT, ...
Get paid easily with our payment APIs. Users can pay easily with credit cards or other cryptocurrencies like Bitcoin, Ethereum, Tron, USDT, ...
- Connected to Blocto App
Once you've integrated with Blocto SDK, your users can manage their assets easily and securely through Blocto App. Your dApp can tap into the vast blockchain ecosystem instantly.

Expand Down