fix: multiple chain setting #431
Merged
+498
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79dade9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sanyu1225
commented
Sep 13, 2024
| * | ||
| * @param networkList - List of networks to add | ||
| * @returns Promise<null> | ||
| */ | ||
| async loadSwitchableNetwork( |
There was a problem hiding this comment.
Only the annotations are left here without changing function to private. Or do you think you can change it directly to a private function? @mordochi
There was a problem hiding this comment.
我覺得可改可不改
不過如果要改的話版號可能就要生中版 不要用 patch
mordochi
previously approved these changes
Sep 23, 2024
| @@ -180,7 +180,6 @@ export default class EthereumProvider | |||
| chainId: `${number}`; | |||
| rpcUrls: string[]; | |||
| }): Promise<void> { | |||
| await this.#getBloctoProperties(); | |||
There was a problem hiding this comment.
[nit] 發現 addToSwitchable 跟 getBloctoProperties 長得好像....看起來好重複😂
| * | ||
| * @param networkList - List of networks to add | ||
| * @returns Promise<null> | ||
| */ | ||
| async loadSwitchableNetwork( |
There was a problem hiding this comment.
我覺得可改可不改
不過如果要改的話版號可能就要生中版 不要用 patch
sanyu1225
force-pushed
the
fix/multiple-chain-setting
branch
from
344478f to
2e2164e
Compare
feat: update the new polygon RPC endpoint
mordochi
approved these changes
Oct 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#addToSwitchablefunction callthis.#getBloctoPropertiesRelated Links
Asana: https://app.asana.com/0/1202921060741036/1208234504509478/f
Checklist
Prerequisite/Related Pull Requests
graph TD A[Client: new BloctoSDK] -->|Set| B[Constructor] B -->|Store| C[this._blocto.unloadedNetwork = switchableChains] D[Client: request 'eth_accounts'] -->|Call| E[EthereumProvider.request] E -->|Call| F[getBloctoProperties] F -->|Check| G{unloadedNetwork exists?} G -->|Yes| H[loadSwitchableNetwork] H -->|Iterate| I[#addToSwitchable] I -->|Originally called| J[getBloctoProperties] J -->|Caused loop| F G -->|No| K[Continue processing] subgraph "Root Cause" I -.->|Circular call| J end