feat: deprecate goerli #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blocto-sdk-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mordochi
approved these changes
Apr 12, 2024
| @@ -13,10 +13,6 @@ export const ContractInfos: ContractInfosType = { | |||
| abi: valueDappAbi, | |||
| address: "0x009c403BdFaE357d82AAef2262a163287c30B739", | |||
| }, | |||
| [EvmChainId.EthereumGoerli]: { | |||
There was a problem hiding this comment.
這邊也有對應到一些其他鏈 goerli testnet 的合約 也可以一起拿掉
| @@ -15,7 +15,6 @@ export enum EvmChain { | |||
|
|
|||
| export enum EvmChainId { | |||
| Ethereum = "0x1", | |||
| EthereumGoerli = "0x5", | |||
There was a problem hiding this comment.
這邊還有對應到一些其他鏈 goerli testnet 的 chain id
✅ Deploy Preview for blocto-sdk-toolkit-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The parts will be implemented in later Pull Requests
Related Links
Asana: https://app.asana.com/0/1203318877558072/1206733445446676/f
Mockup:
Checklist
Prerequisite/Related Pull Requests
Screenshot/Gif