feat: add sendTx feat to UserOp template #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for blocto-sdk-toolkit-testnet failed.
|
mordochi
reviewed
Sep 27, 2023
mordochi
reviewed
Sep 27, 2023
src/components/EvmEditor.tsx
Outdated
Comment on lines
257
to
262
| setRequestObject={([params] = []) => | ||
| setRequestObject({ | ||
| method: "eth_sendTransaction", | ||
| params, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Is there any concern that we update the method like this?
Cuz we can still keep it setRequestObject={setRequestObject} and setTransactionToCallData should be
const setTransactionToCallData = useCallback(
({ params: [tx] = [] }) => {
const { to, value = "0x", data = "0x" } = tx;
...
},
[otherParam, setRequestObject]
);This way we don't have to update src/components/EvmEditor.tsx and src/components/EvmEditors/EvmSendEditor.tsx
mordochi
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The parts will be implemented in later Pull Requests
Related Links
Asana: https://app.asana.com/0/1201812548509877/1205200072749122/f
Mockup:
Checklist
Prerequisite/Related Pull Requests
Screenshot/Gif