Feat/evm batch tx editor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blocto-sdk-toolkit-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mordochi
reviewed
Dec 26, 2023
| setRequestObject, | ||
| account, | ||
| }: EvmBatchTxEditorProps): ReactJSXElement => { | ||
| const [revert, setRevert] = useState<string>("true"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
另外幫我做成 optional 的可以嗎 因為這個 param 其實可以不帶
wallet 理論上還是要用 revert = false 的方式幫處理掉～想讓 QA 也可以測一下 dapp 沒帶的情況 謝謝！
There was a problem hiding this comment.
resolved enhance: optional revert and improve empty tx express
- 新增 unset 處理沒放 revert 的狀況
- revert flag default 已經是 true 了, 但因為 Radio value prop 不收 boolean, 因此 revert state 那裡是放字串, 有加
RevertOptionMap處理最後送進 sdk 的 revert 值
There was a problem hiding this comment.
我是要說 default 放 false lol 講錯了搜哩XDD
貼的那個 spec 就是寫 default false
|
然後 Netlify 上面的 pre-deploy 失敗ㄛ～ 再幫檢查一下 |
mordochi
approved these changes
Dec 29, 2023
q20274982
force-pushed
the
feat/evm-batch-tx-panel
branch
from
9e032ac to
035e585
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add send batch transaction editor in EVM tab
The parts will be implemented in later Pull Requests
Related Links
Asana: https://app.asana.com/0/1201812548509877/1206045904729804/f
Mockup:
Checklist
Prerequisite/Related Pull Requests
Screenshot/Gif