Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor features and improvements #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

minor features and improvements #13

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c000998
json unmarshal for PublicKey
defactojob Aug 29, 2021
95a76d9
text unmarshal (using hex) for private key
defactojob Aug 29, 2021
23da275
token mint support
defactojob Aug 29, 2021
e150624
fixed logMessages typo
defactojob Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions common/public_key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"crypto/sha256"
"encoding/json"
"errors"
"fmt"

"filippo.io/edwards25519"
"github.com/mr-tron/base58"
Expand All @@ -17,6 +18,21 @@ const (

type PublicKey [PublicKeyLength]byte

func (pk *PublicKey) UnmarshalJSON(b []byte) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add test for this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll handle this a bit later

buf, err := base58.Decode(string(b[1 : len(b)-1]))
if err != nil {
return fmt.Errorf("invalid public key: %w", err)
}

if len(buf) != PublicKeyLength {
return errors.New("invalid public key length")
}

copy(pk[:], buf)

return nil
}

func (p PublicKey) String() string {
return p.ToBase58()
}
Expand Down