Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify collection instruction #167

Merged
merged 5 commits into from
May 15, 2024
Merged

Add verify collection instruction #167

merged 5 commits into from
May 15, 2024

Conversation

Trisato
Copy link
Contributor

@Trisato Trisato commented May 14, 2024

When we create a nft and add it to a collection , this instruction can verify the nft as the member of the collection.

@yihau
Copy link
Collaborator

yihau commented May 14, 2024

thank you! do you mind add some tests for them and share the IDL that you're referring to?

@Trisato
Copy link
Contributor Author

Trisato commented May 14, 2024

Alright, will do.

@Trisato
Copy link
Contributor Author

Trisato commented May 15, 2024

@yihau The test case was added, pls review it.
The instruction I added has been test in my app, it can work smoothly.
This is the tx: https://solscan.io/tx/4SvvuBMxfcDo1hTYjxKy1ArJed5sEYQHydeLoZKVC7rqNUwjuFSYWgfWcuMKBdd17FVy1zLAnxG5dYWN3ypfkYFG?cluster=devnet

@Trisato
Copy link
Contributor Author

Trisato commented May 15, 2024

About the IDL, I don't know what is the format standard i should share. I just read the code from mpl token ts code and the IDL definition is in this file:
https://github.com/metaplex-foundation/mpl-token-metadata/blob/main/idls/token_metadata.json
the Instruction is: "VerifyCollection"
If there is any other requirement, pls feel free to let me know.

@yihau
Copy link
Collaborator

yihau commented May 15, 2024

it looks like we lack an option account, collectionAuthorityRecord but I think we can have another PR to fix it. thank you for your contribution!

@yihau yihau merged commit b0b5702 into blocto:main May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants