fix: update password requirements (#4107)

bloom-housing · May 23, 2024 · 1f96fbb · 1f96fbb
1 parent 4e6e1db
commit 1f96fbb
Show file tree

Hide file tree

Showing 47 changed files with 226 additions and 163 deletions.
diff --git a/api/prisma/seed-dev.ts b/api/prisma/seed-dev.ts
@@ -57,6 +57,7 @@ export const devSeeding = async (
       confirmedAt: new Date(),
       jurisdictionIds: [jurisdiction.id],
       acceptedTerms: true,
+      password: 'abcdef',
     }),
   });
   await prismaClient.userAccounts.create({

diff --git a/api/prisma/seed-helpers/user-factory.ts b/api/prisma/seed-helpers/user-factory.ts
@@ -15,13 +15,16 @@ export const userFactory = async (optionalParams?: {
   jurisdictionIds?: string[];
   listings?: string[];
   acceptedTerms?: boolean;
+  password?: string;
 }): Promise<Prisma.UserAccountsCreateInput> => ({
   email:
     optionalParams?.email?.toLocaleLowerCase() ||
     `${randomNoun().toLowerCase()}${randomNoun().toLowerCase()}@${randomAdjective().toLowerCase()}.com`,
   firstName: optionalParams?.firstName || 'First',
   lastName: optionalParams?.lastName || 'Last',
-  passwordHash: await passwordToHash('abcdef'),
+  passwordHash: optionalParams?.password
+    ? await passwordToHash(optionalParams?.password)
+    : await passwordToHash('Abcdef12345!'),
   userRoles: {
     create: {
       isAdmin: optionalParams?.roles?.isAdmin || false,

diff --git a/api/prisma/seed-staging.ts b/api/prisma/seed-staging.ts
@@ -62,6 +62,7 @@ export const stagingSeed = async (
       confirmedAt: new Date(),
       jurisdictionIds: [jurisdiction.id, additionalJurisdiction.id],
       acceptedTerms: true,
+      password: 'abcdef',
     }),
   });
   // create a jurisdictional admin

diff --git a/api/src/utilities/password-regex.ts b/api/src/utilities/password-regex.ts
@@ -1 +1,2 @@
-export const passwordRegex = /^(?=.*[0-9])(?=.*[a-zA-Z])([a-zA-Z0-9]+).{7,}$/;
+export const passwordRegex =
+  /^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9])(?=.*?[#?!@$%^&*-]).{12,}$/;
diff --git a/api/test/integration/ami-chart.e2e-spec.ts b/api/test/integration/ami-chart.e2e-spec.ts
@@ -47,7 +47,7 @@ describe('AmiChart Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/api-key-guard.e2e-spec.ts b/api/test/integration/api-key-guard.e2e-spec.ts
@@ -34,7 +34,7 @@ describe('API Key Guard Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/application-flagged-set.e2e-spec.ts b/api/test/integration/application-flagged-set.e2e-spec.ts
@@ -107,7 +107,7 @@ describe('Application flagged set Controller Tests', () => {
     const res = await request(app.getHttpServer())
       .post('/auth/login')
       .set({ passkey: process.env.API_PASS_KEY || '' })
-      .send({ email: adminUser.email, password: 'abcdef' })
+      .send({ email: adminUser.email, password: 'Abcdef12345!' })
       .expect(201);
     adminAccessToken = res.header?.['set-cookie'].find((cookie) =>
       cookie.startsWith('access-token='),

diff --git a/api/test/integration/application.e2e-spec.ts b/api/test/integration/application.e2e-spec.ts
@@ -105,7 +105,7 @@ describe('Application Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/asset.e2e-spec.ts b/api/test/integration/asset.e2e-spec.ts
@@ -35,7 +35,7 @@ describe('Asset Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/auth.e2e-spec.ts b/api/test/integration/auth.e2e-spec.ts
@@ -55,7 +55,7 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
         mfaCode: storedUser.singleUseCode,
         mfaType: MfaType.email,
       } as Login)
@@ -98,7 +98,7 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 
@@ -139,7 +139,7 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 
@@ -192,7 +192,7 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
         mfaType: MfaType.sms,
       } as RequestMfaCode)
       .expect(201);
@@ -249,8 +249,8 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef123',
-        passwordConfirmation: 'abcdef123',
+        password: 'Abcdef12345!',
+        passwordConfirmation: 'Abcdef12345!',
         token,
       } as UpdatePassword)
       .expect(200);
@@ -346,7 +346,7 @@ describe('Auth Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
     await request(app.getHttpServer())

diff --git a/api/test/integration/jurisdiction.e2e-spec.ts b/api/test/integration/jurisdiction.e2e-spec.ts
@@ -39,7 +39,7 @@ describe('Jurisdiction Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/listing.e2e-spec.ts b/api/test/integration/listing.e2e-spec.ts
@@ -92,7 +92,7 @@ describe('Listing Controller Tests', () => {
     const res = await request(app.getHttpServer())
       .post('/auth/login')
       .set({ passkey: process.env.API_PASS_KEY || '' })
-      .send({ email: adminUser.email, password: 'abcdef' })
+      .send({ email: adminUser.email, password: 'Abcdef12345!' })
       .expect(201);
     adminAccessToken = res.header?.['set-cookie'].find((cookie) =>
       cookie.startsWith('access-token='),
@@ -811,7 +811,7 @@ describe('Listing Controller Tests', () => {
       const res = await request(app.getHttpServer())
         .post('/auth/login')
         .set({ passkey: process.env.API_PASS_KEY || '' })
-        .send({ email: adminUser.email, password: 'abcdef' })
+        .send({ email: adminUser.email, password: 'Abcdef12345!' })
         .expect(201);
 
       adminAccessToken = res.header?.['set-cookie'].find((cookie) =>
@@ -823,7 +823,7 @@ describe('Listing Controller Tests', () => {
       const res = await request(app.getHttpServer())
         .post('/auth/login')
         .set({ passkey: process.env.API_PASS_KEY || '' })
-        .send({ email: partnerUser.email, password: 'abcdef' })
+        .send({ email: partnerUser.email, password: 'Abcdef12345!' })
         .expect(201);
 
       const partnerAccessToken = res.header?.['set-cookie'].find((cookie) =>

diff --git a/api/test/integration/multiselect-question.e2e-spec.ts b/api/test/integration/multiselect-question.e2e-spec.ts
@@ -49,7 +49,7 @@ describe('MultiselectQuestion Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/helpers.ts b/api/test/integration/permission-tests/helpers.ts
@@ -268,7 +268,7 @@ export const buildUserCreateMock = (
   return {
     firstName: 'Public User firstName',
     lastName: 'Public User lastName',
-    password: 'example password 1',
+    password: 'Abcdef12345!',
     email,
     jurisdictions: [{ id: jurisId }],
   } as unknown as UserCreate;
@@ -281,7 +281,7 @@ export const buildUserInviteMock = (
   return {
     firstName: 'Partner User firstName',
     lastName: 'Partner User lastName',
-    password: 'example password 1',
+    password: 'Abcdef12345!',
     email,
     jurisdictions: [{ id: jurisId }],
     agreedToTermsOfService: true,

diff --git a/api/test/integration/permission-tests/permission-as-admin.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-admin.e2e-spec.ts
@@ -113,7 +113,7 @@ describe('Testing Permissioning of endpoints as Admin User', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts
@@ -117,7 +117,7 @@ describe('Testing Permissioning of endpoints as Jurisdictional Admin in the corr
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/permission-as-juris-admin-wrong-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-juris-admin-wrong-juris.e2e-spec.ts
@@ -118,7 +118,7 @@ describe('Testing Permissioning of endpoints as Jurisdictional Admin in the wron
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/permission-as-partner-correct-listing.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-partner-correct-listing.e2e-spec.ts
@@ -162,7 +162,7 @@ describe('Testing Permissioning of endpoints as partner with correct listing', (
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/permission-as-partner-wrong-listing.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-partner-wrong-listing.e2e-spec.ts
@@ -169,7 +169,7 @@ describe('Testing Permissioning of endpoints as partner with wrong listing', ()
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/permission-tests/permission-as-public.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-public.e2e-spec.ts
@@ -108,7 +108,7 @@ describe('Testing Permissioning of endpoints as public user', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
     storedUserId = storedUser.id;

diff --git a/api/test/integration/reserved-community-type.e2e-spec.ts b/api/test/integration/reserved-community-type.e2e-spec.ts
@@ -50,7 +50,7 @@ describe('ReservedCommunityType Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/unit-accessibility-priority-type.e2e-spec.ts b/api/test/integration/unit-accessibility-priority-type.e2e-spec.ts
@@ -41,7 +41,7 @@ describe('UnitAccessibilityPriorityType Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/unit-rent-type.e2e-spec.ts b/api/test/integration/unit-rent-type.e2e-spec.ts
@@ -38,7 +38,7 @@ describe('UnitRentType Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/unit-type.e2e-spec.ts b/api/test/integration/unit-type.e2e-spec.ts
@@ -43,7 +43,7 @@ describe('UnitType Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 

diff --git a/api/test/integration/user.e2e-spec.ts b/api/test/integration/user.e2e-spec.ts
@@ -71,7 +71,7 @@ describe('User Controller Tests', () => {
       .set({ passkey: process.env.API_PASS_KEY || '' })
       .send({
         email: storedUser.email,
-        password: 'abcdef',
+        password: 'Abcdef12345!',
       } as Login)
       .expect(201);
 
@@ -576,7 +576,7 @@ describe('User Controller Tests', () => {
       .send({
         firstName: 'Public User firstName',
         lastName: 'Public User lastName',
-        password: 'example password 1',
+        password: 'Abcdef12345!',
         email: '[email protected]',
         jurisdictions: [{ id: juris.id }],
       } as UserCreate)
@@ -602,7 +602,7 @@ describe('User Controller Tests', () => {
     );
   });
 
-  it('should create parter user', async () => {
+  it('should create partner user', async () => {
     const juris = await prisma.jurisdictions.create({
       data: jurisdictionFactory(),
     });
@@ -613,7 +613,7 @@ describe('User Controller Tests', () => {
       .send({
         firstName: 'Partner User firstName',
         lastName: 'Partner User lastName',
-        password: 'example password 1',
+        password: 'Abcdef12345!',
         email: '[email protected]',
         jurisdictions: [{ id: juris.id }],
         agreedToTermsOfService: true,