You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an autofill test run to the "Submit" test in submit-application.spec.ts, first applying to Elm Village then applying with autofill to Blue Sky apartments -- the idea here is that it's most likely a user would autofill a different application than the one they initially applied to
Removes the minimal application test for Blue Sky Apartments
Edits the submitApplication function and the necessary step functions in command.js to take in an autofill boolean arg (if autofill, we skip filling out most fields)
To fill out fields in Blue Sky that are not in Elm Village
To fill out fields removed by Autofill Cleaner
Because submitApplication needs this mockData to compare against in the summary step
How Can This Be Tested/Reviewed?
Run yarn test in sites/public and watch the "Submit" test from submit-appication.spec.ts
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
Heya @adriencyberspace ! Do you mind filling out the PR template description? With some background on the goal here and any technical choices you made if there's any relevant ones. It doesn't have to be long. The "how can we test this" section is more self-explanatory on this one.
The reason will be displayed to describe this comment to others. Learn more.
For some reason the test keeps getting stuck locally for me on the blue sky application on the "Do you anticipate any changes in your household in the next 12 months, such as the number of people?" question. This test is passing in circleCI though so maybe it's something strange locally for me
ready to mergeShould be applied when a PR has been reviewed and approved
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adriencyberspace
changed the title
ludtkemorgan
added
ready to merge
This PR addresses #3385
Description
This PR:
"Submit"test insubmit-application.spec.ts, first applying to Elm Village then applying with autofill to Blue Sky apartments -- the idea here is that it's most likely a user would autofill a different application than the one they initially applied tosubmitApplicationfunction and the necessary step functions incommand.jsto take in anautofillboolean arg (if autofill, we skip filling out most fields)autofillBlueSkyApplication, reasons:How Can This Be Tested/Reviewed?
Run yarn test in sites/public and watch the
"Submit"test fromsubmit-appication.spec.tsAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: