Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose resetNextUuid #160

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: expose resetNextUuid #160

merged 1 commit into from
Nov 13, 2024

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Nov 13, 2024

Pull Request Template

#159

Description

This PR exposes the resetNextUuid function provided by React-Accessible-Accordion. This will allow consumers to stabilize the id's used in the Accordion logic.

How Can This Be Tested/Reviewed?

This makes no functionality changes to any components.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have made any corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated stories if new changes are not captured in Storybook
  • New and existing unit tests pass locally with my changes
  • I have exported any new pieces added to ui-components
  • I have documented this change in the changelog, and any breaking changes are well described

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Either review the Storybook preview or pull the changes down locally and test that the acceptance criteria is met
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On merge, squash commits.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for storybook-bloom-dev ready!

Name Link
🔨 Latest commit f4b7ed2
🔍 Latest deploy log https://app.netlify.com/sites/storybook-bloom-dev/deploys/6734db34ace20c0008c51c41
😎 Deploy Preview https://deploy-preview-160--storybook-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@cade-exygy cade-exygy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@chadbrokaw chadbrokaw merged commit c5c78be into main Nov 13, 2024
8 checks passed
Copy link

🎉 This PR is included in version 12.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants