Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-7671 Enhance assign users UI #468

Merged
merged 1 commit into from
Oct 1, 2024
Merged

RDISCROWD-7671 Enhance assign users UI #468

merged 1 commit into from
Oct 1, 2024

Conversation

kbecker42
Copy link

@kbecker42 kbecker42 commented Sep 30, 2024 •
edited
Loading

  • Sort users in alphabetical order by last name.
  • Hide disabled users.
  • Show email address in tooltip.

Screenshot

screenshot

Re: bloomberg/pybossa#975

@kbecker42
Sort assigned users.
281c6cf 
Hide disabled users.
Show email address in tooltip.
@kbecker42 kbecker42 requested review from XiChenn and n00rsy September 30, 2024 17:08
n00rsy
n00rsy reviewed Oct 1, 2024
View reviewed changes
Copy link

@n00rsy n00rsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see where disabled users are hidden (unless this was done previously)

@kbecker42
Copy link
Author

Don't see where disabled users are hidden (unless this was done previously)

The filter for enabled users is located here.

n00rsy
n00rsy approved these changes Oct 1, 2024
View reviewed changes
Copy link

@n00rsy n00rsy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can be merged upon test cases passing. Thanks!

@kbecker42 kbecker42 merged commit e5a2b53 into main Oct 1, 2024
2 of 4 checks passed
@kbecker42 kbecker42 mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n00rsy n00rsy n00rsy approved these changes

@XiChenn XiChenn Awaiting requested review from XiChenn

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbecker42 @n00rsy