RDISCROWD-7660 move authorized services section #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbecker42
approved these changes
Nov 19, 2024
|
|
||
| {% for (form_name, display, form) in forms %} | ||
| <h3>{{display}}</h3> | ||
| {{render_form(form, form_id=form_name, action_url=url_for('project.ext_config', short_name=project.short_name), action_text='Submit', class_='', btn_name=form_name, btn_class='btn btn-default', btn_value=None)}} | ||
| {% endfor %} | ||
|
|
||
| <h3>Authorized Services</h3> | ||
| {% if authorized_services is defined and authorized_services|length > 0 %} |
There was a problem hiding this comment.
Can this be optimized to:
{% if authorized_services %}There was a problem hiding this comment.
From what I know about Jinja templating language, no: https://www.shellhacks.com/jinja2-check-if-variable-empty-exists-defined-true/
There was a problem hiding this comment.
Feel free to test the optimized version. Otherwise, either would be fine. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #RDISCROWD-7660