ITSE-3681 replace global variables with facter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchepkov
reviewed
Sep 4, 2018
manifests/server.pp
Outdated
| $plugin_nginx = false, | ||
| $plugin_xcache = false, | ||
| $selinux = $::selinux, | ||
| $selinux = $facter['os']['selinux']['enabled'], |
vchepkov
reviewed
Sep 4, 2018
manifests/client.pp
Outdated
| if $::nagios_pci_mptsas { class { '::nagios::check::mptsas': } } | ||
| if $::nagios_mysqld { | ||
| case $::operatingsystem { | ||
| if $facts['nagios_couchbase'] { class { '::nagios::check::couchbase': } } |
There was a problem hiding this comment.
class doesn't need :: either
in fact, class notation here is unnecessary, should be include nagios::check::couchbase instead
vchepkov
reviewed
Sep 4, 2018
manifests/client.pp
Outdated
| } | ||
|
|
||
| # With selinux, some nrpe plugins require additional rules to work | ||
| if $selinux and $::selinux_enforced { | ||
| if $selinux and $facts['selinux_enforced'] { |
There was a problem hiding this comment.
for uniformity, it's os.selinux.enforced
wamui33
force-pushed
the
ITSE-3681-replace-global-scope-variables-with-facts
branch
from
8bbf5cb to
ed9bb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.