feat: Add LRU cache alongside redis #6
Conversation
| await Promise.allSettled( | ||
| cachedIdls.map(async (res, i) => { | ||
| const programId = programIds[i]!; |
There was a problem hiding this comment.
Why do we run allSettled on an awaited Promise<(string | null)[]>?
There was a problem hiding this comment.
It is mostly because missing idls need to make an RPC call to solana-fm to retrieve and store that in the cache. See line below:
const idl = await getProgramIdl(programId);| await redisClient.connect(); | ||
|
|
||
| const lruCache = new LRUCache<string, string>({ | ||
| max: LRU_CACHE_MAX_ITEMS_COUNT, |
There was a problem hiding this comment.
We should use the same ttl for the in-memory cache as redis
| const client = createClient({ | ||
| url: config.REDIS_URL, | ||
| }); | ||
| const LRU_CACHE_MAX_ITEMS_COUNT = 100; |
There was a problem hiding this comment.
We could probably bump this to 1000 without any problems right?
There was a problem hiding this comment.
Size of IDL is quite big, but I think node would be fine even with that.
btw I've tested that even a LRU cache of 100 items is going to decrease redis call rate by >90%
There was a problem hiding this comment.
Size of IDL is quite big, but I think node would be fine even with that. btw I've tested that even a LRU cache of 100 items is going to decrease redis call rate by >90%
Ahh nice! 👍 I'm fine with either 100 or 1000 then
This PR addes LRU cache alongside redis for better performance.
Right now LRU cache size is set to 100 items