Bug/654 redirect to stats.php on disconnect #672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue outlined by #654 is caused when the client disconnects from the internet and can no longer send a request to
/ajax/stats.php
. The code that causes this is a commit made to solve issue #474 which sends the entire browser to the URL/ajax/stats.php/
because the background request failed.The solution proposed by this PR works around both of these issues by create a way to create exception to the redirection when the request fails by simply passing false to the optional parameter
redirectOnFail
.This is by no means a proper solutions and a better solution for both issue #654 and #474 might be needed to be discussed.