Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog formatting #680

Merged

Conversation

andrey-utkin
Copy link
Contributor

@andrey-utkin andrey-utkin commented Apr 24, 2024

The first commit is important as the build fails without it.

The way to test this is to run dpkg-parsechangelog -STimestamp --all -l debian/changelog.
The expected result is a number, a unix timestamp. No warnings.

This is what this outputs for current master:

dpkg-parsechangelog: warning:     debian/changelog(l10): badly formatted trailer line
LINE:  -- Andriy Utkin <[email protected]> Wed, Mar 27 2024 18:40:00 -0000
dpkg-parsechangelog: warning:     debian/changelog(l12): found start of entry where expected more change data or trailer
LINE: bluecherry (3:3.1.0-rc10) focal bionic buster groovy hirsute bullseye jammy; urgency=low
dpkg-parsechangelog: warning:     debian/changelog(l21): ignoring invalid week day 'Thr'
LINE:  -- Curtis Hall <[email protected]>  Thr, 15 Feb 2024 16:47:00 -0600
dpkg-parsechangelog: warning:     debian/changelog(l1068): badly formatted trailer line
LINE:  -- Ismael Luceno <[email protected]>  Tue 12 Mar 2013 15:23:01 -0300
dpkg-parsechangelog: warning:     debian/changelog(l1070): found start of entry where expected more change data or trailer
LINE: bluecherry (1:2.0.2-1) lucid; urgency=low

(no timestamp in output).

Date must follow the maintainer name after two spaces.
Order of date fields is fixed, month follows the day.

These formatting rules were violated which caused package building to
fail.
These don't matter for building, but some of them emit warnings
regularly.
@andrey-utkin andrey-utkin requested a review from curtishall April 24, 2024 11:14
@curtishall curtishall merged commit 7f50dc6 into bluecherrydvr:master Apr 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants