Skip to content

Commit

Permalink
Bugfix Precip diagnostics
Browse files Browse the repository at this point in the history
GFDL MP developer (Linjiong Zhou) provided the code changes. The fix solved the problem of overly produced precip and sensitivity to microphysics timestep
	modified:   module_gfdl_cld_mp.F90
  • Loading branch information
bluefinweiwei committed Sep 11, 2024
1 parent d639a72 commit f6d0b39
Showing 1 changed file with 7 additions and 12 deletions.
19 changes: 7 additions & 12 deletions physics/MP/GFDL_2022_v3/module_gfdl_cld_mp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ subroutine mpdrv (hydrostatic, ua, va, wa, delp, pt, qv, ql, qr, qi, qs, qg, &
! unit convert to mm/day
! -----------------------------------------------------------------------

convt = 86400. * rgrav / dts
convt = 86400. * rgrav / dtm

do i = is, ie

Expand Down Expand Up @@ -1433,7 +1433,7 @@ subroutine mpdrv (hydrostatic, ua, va, wa, delp, pt, qv, ql, qr, qi, qs, qg, &
if (fix_negative) &
call neg_adj (ks, ke, tz, dp, qvz, qlz, qrz, qiz, qsz, qgz, cond)

condensation (i) = condensation (i) + cond * convt * ntimes
condensation (i) = condensation (i) + cond * convt

! -----------------------------------------------------------------------
! fast microphysics loop
Expand Down Expand Up @@ -1946,16 +1946,11 @@ subroutine mp_full (ks, ke, ntimes, tz, qv, ql, qr, qi, qs, qg, dp, dz, u, v, w,
snow = snow + s1 * convt
graupel = graupel + g1 * convt

!prefluxw = prefluxw + pfw * convt
!prefluxr = prefluxr + pfr * convt
!prefluxi = prefluxi + pfi * convt
!prefluxs = prefluxs + pfs * convt
!prefluxg = prefluxg + pfg * convt
prefluxw = prefluxw + pfw
prefluxr = prefluxr + pfr
prefluxi = prefluxi + pfi
prefluxs = prefluxs + pfs
prefluxg = prefluxg + pfg
prefluxw = prefluxw + pfw * convt
prefluxr = prefluxr + pfr * convt
prefluxi = prefluxi + pfi * convt
prefluxs = prefluxs + pfs * convt
prefluxg = prefluxg + pfg * convt

! -----------------------------------------------------------------------
! warm rain cloud microphysics
Expand Down

0 comments on commit f6d0b39

Please sign in to comment.