update golangci-lint

.github/workflows/lint.yml

@@ -19,7 +19,7 @@ jobs:
 
     - uses: golangci/golangci-lint-action@v3
       with:
-        version: v1.55.0
+        version: v1.55.2
 
   go-mod-tidy:
     runs-on: ubuntu-20.04

.golangci.yml

@@ -1,7 +1,10 @@
 linters:
   enable:
+  - asciicheck
+  - bidichk
   - bodyclose
   - dupl
+  - errorlint
   - exportloopref
   - gochecknoinits
   - gocritic
@@ -13,6 +16,7 @@ linters:
   - prealloc
   - revive
   - unconvert
+  - tparallel
   - wastedassign
   - whitespace
 

Makefile

@@ -1,5 +1,5 @@
 BASE_IMAGE = golang:1.21-alpine3.18
-LINT_IMAGE = golangci/golangci-lint:v1.55.0
+LINT_IMAGE = golangci/golangci-lint:v1.55.2
 
 .PHONY: $(shell ls)
 

channel.go

@@ -3,6 +3,7 @@ package gomavlib
 import (
 	"context"
 	"crypto/rand"
+	"errors"
 	"io"
 
 	"github.com/bluenviron/gomavlib/v2/pkg/frame"
@@ -141,7 +142,8 @@ func (ch *Channel) runReader(readerDone chan struct{}) {
 	for {
 		fr, err := ch.frw.Read()
 		if err != nil {
-			if _, ok := err.(*frame.ReadError); ok {
+			var eerr frame.ReadError
+			if errors.As(err, &eerr) {
 				ch.n.pushEvent(&EventParseError{err, ch})
 				continue
 			}

channel_provider.go

@@ -1,6 +1,7 @@
 package gomavlib
 
 import (
+	"errors"
 	"fmt"
 )
 
@@ -35,15 +36,15 @@ func (cp *channelProvider) run() {
 	for {
 		label, rwc, err := cp.eca.provide()
 		if err != nil {
-			if err != errTerminated {
+			if !errors.Is(err, errTerminated) {
 				panic("errTerminated is the only error allowed here")
 			}
 			break
 		}
 
 		ch, err := newChannel(cp.n, cp.eca, label, rwc)
 		if err != nil {
-			panic(fmt.Errorf("newChannel unexpected error: %s", err))
+			panic(fmt.Errorf("newChannel unexpected error: %w", err))
 		}
 
 		cp.n.newChannel(ch)

pkg/conversion/conversion.go

@@ -319,7 +319,7 @@ func processDefinition(
 
 	def, err := definitionDecode(content)
 	if err != nil {
-		return nil, fmt.Errorf("unable to decode: %s", err)
+		return nil, fmt.Errorf("unable to decode: %w", err)
 	}
 
 	addrPath, _ := filepath.Split(defAddr)
@@ -393,14 +393,14 @@ func getDefinition(isRemote bool, defAddr string) ([]byte, error) {
 	if isRemote {
 		byt, err := download(defAddr)
 		if err != nil {
-			return nil, fmt.Errorf("unable to download: %s", err)
+			return nil, fmt.Errorf("unable to download: %w", err)
 		}
 		return byt, nil
 	}
 
 	byt, err := os.ReadFile(defAddr)
 	if err != nil {
-		return nil, fmt.Errorf("unable to open: %s", err)
+		return nil, fmt.Errorf("unable to open: %w", err)
 	}
 	return byt, nil
 }

pkg/dialect/readwriter.go

@@ -24,7 +24,7 @@ func NewReadWriter(d *Dialect) (*ReadWriter, error) {
 
 		de, err := message.NewReadWriter(m)
 		if err != nil {
-			return nil, fmt.Errorf("message %T: %s", m, err)
+			return nil, fmt.Errorf("message %T: %w", m, err)
 		}
 
 		rw.messageRWs[m.GetID()] = de

pkg/frame/reader.go

@@ -22,12 +22,12 @@ type ReadError struct {
 	str string
 }
 
-func (e *ReadError) Error() string {
+func (e ReadError) Error() string {
 	return e.str
 }
 
-func newError(format string, args ...interface{}) *ReadError {
-	return &ReadError{
+func newError(format string, args ...interface{}) ReadError {
+	return ReadError{
 		str: fmt.Sprintf(format, args...),
 	}
 }