Update: crate to bluerobotics-ping #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulTrombin
requested review from
patrickelectric and
joaoantoniocardoso
and removed request for
patrickelectric
RaulTrombin
force-pushed
the
create_crate
branch
3 times, most recently
from
f11e70e
to
285e2b4
Compare
|
This PR is in conflict |
RaulTrombin
force-pushed
the
create_crate
branch
from
285e2b4
to
1ce42b7
Compare
rebased |
patrickelectric
requested changes
Apr 25, 2024
| @@ -1,2 +1,2 @@ | |||
| # ping-rs | |||
| https://docs.bluerobotics.com/ping-rs/ping_rs/ | |||
| https://docs.bluerobotics.com/ping-rs/bluerobotics_ping/ | |||
There was a problem hiding this comment.
This is not the name of the repository, we also don´t intend to change since this matches with all others ping repositories that we currently have already, it's ok to have the crate with a difference name though.
RaulTrombin
force-pushed
the
create_crate
branch
from
1ce42b7
to
e297593
Compare
RaulTrombin
force-pushed
the
create_crate
branch
2 times, most recently
from
a252300
to
09d3ca6
Compare
patrickelectric
requested changes
Apr 25, 2024
README.md
Outdated
| @@ -1,2 +1,2 @@ | |||
| # ping-rs | |||
| https://docs.bluerobotics.com/ping-rs/ping_rs/ | |||
| https://docs.bluerobotics.com/ping-rs/ping-rs/ | |||
There was a problem hiding this comment.
The first one is the repository name and the second is the crate name, since you changed the crate name the link should also take that
RaulTrombin
force-pushed
the
create_crate
branch
from
09d3ca6
to
842c3b7
Compare
RaulTrombin
force-pushed
the
create_crate
branch
from
842c3b7
to
6dbd1b2
Compare
patrickelectric
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping-rs is already in use.