Add: Automatic function generation for get,set and control #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulTrombin
requested review from
patrickelectric and
joaoantoniocardoso
and removed request for
patrickelectric
patrickelectric
requested changes
May 2, 2024
build/parser.rs
Outdated
| } | ||
| } | ||
| impl Device { | ||
| pub fn new(port: tokio_serial::SerialStream) -> Self { |
There was a problem hiding this comment.
We should not use serial, but an abstraction over io. This should work with serial, tcp, udp and file.
There was a problem hiding this comment.
Please check proposal
…heir required associate methods
This was referenced May 6, 2024
RaulTrombin
changed the title
RaulTrombin
force-pushed
the
fn_gen
branch
2 times, most recently
from
5f34b08
to
34ff863
Compare
…r Ping1D and Ping360
|
@patrickelectric @joaoantoniocardoso |
|
@patrickelectric |
patrickelectric
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
This PR adds an enum 'category' to make it easier to compose each kind of function.
All the functions related to ping1d/ping360 are now auto-generated.
The functions' set has the parameters exactly as "Set-any-structures". Each set function has a subscriber which waits until receiving its corresponding Ack code or error.
Each setting function simply sends the corresponding request (Ack codes after setting request weren't observed). Each get function has its own subscriber that waits to match the corresponding structure. Functions also have their descriptions.
All the logic towards sending, subscribing, receiving with ack check, and timeout remains the same and is defined in PingDevice.
The Ping1D has been moved to a builder and is now ping1d::Device. ping1D::Device is reimported as Ping1D, as is Ping360 which actually has all functions attached to it.
Next steps: