Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: UDP stream option to ping1d example #34

Merged

Conversation

RaulTrombin
Copy link
Member

@RaulTrombin RaulTrombin commented May 7, 2024

This PR adds UDP support to the ping1d example, along with related instructions.

The options 'serial_port' and 'udp_port' are exclusive.

@RaulTrombin RaulTrombin force-pushed the add_udp_stream_example branch 2 times, most recently from 63d6f12 to a996b44 Compare May 13, 2024 18:44
@RaulTrombin RaulTrombin changed the title Add: UDP stream option to ping1d example [WIP] Add: UDP stream option to ping1d example May 13, 2024
@RaulTrombin RaulTrombin force-pushed the add_udp_stream_example branch 2 times, most recently from 5b09a9f to 29c9769 Compare May 13, 2024 20:26
@RaulTrombin RaulTrombin marked this pull request as ready for review May 13, 2024 23:57
port_name: PathBuf,
#[arg(short, long, default_value_t = 115200)]
baud_rate: u32,
#[arg(long, group = "source",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an unnecessary double space before group

Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@patrickelectric patrickelectric merged commit 669c5c9 into bluerobotics:master May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants