-
Notifications
You must be signed in to change notification settings - Fork 609
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Appview: apply needs-review to notifications, threads, quote lists (#…
…3058) * appview: apply needs-review to notifications, threads, quote lists * appview: tests for needs-review labels * appview: apply needs-review to mentions
- Loading branch information
Showing
7 changed files
with
217 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| import { AtpAgent } from '@atproto/api' | ||
| import { TestNetwork, SeedClient, basicSeed } from '@atproto/dev-env' | ||
| import { ids } from '../../src/lexicon/lexicons' | ||
| import assert from 'assert' | ||
| import { isThreadViewPost } from '../../src/lexicon/types/app/bsky/feed/defs' | ||
|
|
||
| describe('bsky needs-review labels', () => { | ||
| let network: TestNetwork | ||
| let agent: AtpAgent | ||
| let sc: SeedClient | ||
|
|
||
| beforeAll(async () => { | ||
| network = await TestNetwork.create({ | ||
| dbPostgresSchema: 'bsky_views_needs_review_labels', | ||
| }) | ||
| agent = network.bsky.getClient() | ||
| sc = network.getSeedClient() | ||
| await basicSeed(sc) | ||
|
|
||
| await sc.createAccount('geoff', { | ||
| email: '[email protected]', | ||
| handle: 'geoff.test', | ||
| password: 'geoff', | ||
| }) | ||
|
|
||
| await sc.reply( | ||
| sc.dids.geoff, | ||
| sc.posts[sc.dids.alice][0].ref, | ||
| sc.posts[sc.dids.alice][0].ref, | ||
| 'my name geoff', | ||
| ) | ||
|
|
||
| await sc.post( | ||
| sc.dids.geoff, | ||
| 'her name alice', | ||
| undefined, | ||
| undefined, | ||
| sc.posts[sc.dids.alice][0].ref, | ||
| ) | ||
|
|
||
| await sc.follow(sc.dids.bob, sc.dids.geoff) | ||
|
|
||
| await network.processAll() | ||
|
|
||
| AtpAgent.configure({ appLabelers: [network.ozone.ctx.cfg.service.did] }) | ||
| await network.bsky.db.db | ||
| .insertInto('label') | ||
| .values({ | ||
| src: network.ozone.ctx.cfg.service.did, | ||
| uri: sc.dids.geoff, | ||
| cid: '', | ||
| val: 'needs-review', | ||
| neg: false, | ||
| cts: new Date().toISOString(), | ||
| }) | ||
| .execute() | ||
| }) | ||
|
|
||
| afterAll(async () => { | ||
| await network.close() | ||
| }) | ||
|
|
||
| it('applies to thread replies.', async () => { | ||
| const { | ||
| data: { thread }, | ||
| } = await agent.app.bsky.feed.getPostThread({ | ||
| uri: sc.posts[sc.dids.alice][0].ref.uriStr, | ||
| }) | ||
| assert(isThreadViewPost(thread)) | ||
| expect( | ||
| thread.replies?.some((reply) => { | ||
| return ( | ||
| isThreadViewPost(reply) && reply.post.author.did === sc.dids.geoff | ||
| ) | ||
| }), | ||
| ).toBe(false) | ||
| }) | ||
|
|
||
| it('applies to quote lists.', async () => { | ||
| const { | ||
| data: { posts }, | ||
| } = await agent.app.bsky.feed.getQuotes({ | ||
| uri: sc.posts[sc.dids.alice][0].ref.uriStr, | ||
| }) | ||
| expect( | ||
| posts.some((post) => { | ||
| return post.author.did === sc.dids.geoff | ||
| }), | ||
| ).toBe(false) | ||
| }) | ||
|
|
||
| it('applies to reply, quote, and mention notifications.', async () => { | ||
| const { | ||
| data: { notifications }, | ||
| } = await agent.app.bsky.notification.listNotifications( | ||
| {}, | ||
| { | ||
| headers: await network.serviceHeaders( | ||
| sc.dids.alice, | ||
| ids.AppBskyNotificationListNotifications, | ||
| ), | ||
| }, | ||
| ) | ||
| expect( | ||
| notifications.some((notif) => { | ||
| return notif.reason === 'reply' && notif.author.did === sc.dids.geoff | ||
| }), | ||
| ).toBe(false) | ||
| expect( | ||
| notifications.some((notif) => { | ||
| return notif.reason === 'quote' && notif.author.did === sc.dids.geoff | ||
| }), | ||
| ).toBe(false) | ||
| expect( | ||
| notifications.some((notif) => { | ||
| return notif.reason === 'mention' && notif.author.did === sc.dids.geoff | ||
| }), | ||
| ).toBe(false) | ||
| }) | ||
|
|
||
| it('does not apply to self.', async () => { | ||
| const { | ||
| data: { thread }, | ||
| } = await agent.app.bsky.feed.getPostThread( | ||
| { | ||
| uri: sc.posts[sc.dids.alice][0].ref.uriStr, | ||
| }, | ||
| { | ||
| headers: await network.serviceHeaders( | ||
| sc.dids.geoff, | ||
| ids.AppBskyFeedGetPostThread, | ||
| ), | ||
| }, | ||
| ) | ||
| assert(isThreadViewPost(thread)) | ||
| expect( | ||
| thread.replies?.some((reply) => { | ||
| return ( | ||
| isThreadViewPost(reply) && reply.post.author.did === sc.dids.geoff | ||
| ) | ||
| }), | ||
| ).toBe(true) | ||
| }) | ||
|
|
||
| it('does not apply to followers.', async () => { | ||
| const { | ||
| data: { thread }, | ||
| } = await agent.app.bsky.feed.getPostThread( | ||
| { | ||
| uri: sc.posts[sc.dids.alice][0].ref.uriStr, | ||
| }, | ||
| { | ||
| headers: await network.serviceHeaders( | ||
| sc.dids.bob, // follows geoff | ||
| ids.AppBskyFeedGetPostThread, | ||
| ), | ||
| }, | ||
| ) | ||
| assert(isThreadViewPost(thread)) | ||
| expect( | ||
| thread.replies?.some((reply) => { | ||
| return ( | ||
| isThreadViewPost(reply) && reply.post.author.did === sc.dids.geoff | ||
| ) | ||
| }), | ||
| ).toBe(true) | ||
| }) | ||
| }) |
File renamed without changes.