Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix @ popup for non-latin chars #7487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oprudkyi
Copy link

@gaearon
Copy link
Collaborator

gaearon commented Jan 20, 2025

This seems a bit too broad?

@oprudkyi
Copy link
Author

oprudkyi commented Jan 20, 2025

@gaearon
as far as I understand, searchActorsTypeahead now searches in profile titles , so there might be any character (at least on web ui it passes everything down to search fn )

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Yea but we'd probably still want to exclude punctuation? Can we keep this to international alphanumeric?

@oprudkyi oprudkyi force-pushed the android_mentions_fix branch from 8cb25a4 to b5b8ba2 Compare January 22, 2025 05:45
@oprudkyi
Copy link
Author

@gaearon I have updated code
though as for me it is now differs from web ui (web supports punctuation as well)

@oprudkyi oprudkyi force-pushed the android_mentions_fix branch from b5b8ba2 to 3b46152 Compare January 23, 2025 00:10
@oprudkyi
Copy link
Author

@gaearon
I forgot to add numerics. Fixed now
current version

  let re = /(^|\s)@([\p{L}\d]*)/giu

@oprudkyi oprudkyi force-pushed the android_mentions_fix branch from 3b46152 to 9e774bc Compare January 26, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants