Preserve whitespace after @mention on web #7562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just tested and it appears to now work as expected. |
|
I have noticed one thing though (I don't know if this is possible to also 'fix'?).... This PR does now add a space after the @mention which now matches mobile behaviour. But on mobile when you start a new post the @mention is blue (resolved to link) where as on web the @mention remains black. Only if you click on the name and select will it turn blue. It would appear on mobile there is some event which, on text change, resolves any names, links etc in the text to blue. When you do eventually post it does add the @mention link later but while editing it is not blue. |
|
Example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On web, clicking New post from the Profile page should open the composer prefilled with “@account ”, but the trailing space is missing.
Fixes #7476.
Fix described on ueberdosis/tiptap#5158.