Improved search language select #7591
Open
+210
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mozzius
force-pushed
the
samuel/search-lang-select-revamp
branch
from
715a3fc to
70a0b71
Compare
arcalinea
temporarily deployed
to
samuel/search-lang-select-revamp - social-app PR #7591
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #7590
I hate react-native-picker-select with all my heart. Rewrites it to use a
MenucomponentNote: I had to add a hack to cap the dropdown height, to prevent it just going offscreen. I will look at fixing this properly - unfortunately seems there's a bunch of open issues regarding this problem (radix-ui/primitives#2786)
Native
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-26.at.09.18.47.mp4
Web
Screen.Recording.2025-01-26.at.09.17.35.mov
Test plan
Confirm functionality is the same