Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved search language select #7591

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+210 −152
Open

Improved search language select #7591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
63b93e0
search input revamp
mozzius Jan 25, 2025
668ae9a
fix web
mozzius Jan 25, 2025
dc2dae5
rm "useThemeNew"
mozzius Jan 25, 2025
dc42469
fix overlap during transition
mozzius Jan 28, 2025
eb6d8f9
animate header properly
mozzius Jan 28, 2025
c235869
reduce gap
mozzius Jan 28, 2025
e47fc68
animate cancel button in
mozzius Jan 30, 2025
18d8d36
replace with Menu
mozzius Jan 25, 2025
b929a98
new icon for native
mozzius Jan 26, 2025
70a0b71
hackfix radix dropdown height
mozzius Jan 26, 2025
16c45be
fix jsx
mozzius Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/icons/chevronTopBottom_stroke2_corner0_rounded.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions src/alf/atoms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@
overflow_hidden: {
overflow: 'hidden',
},
/**
* @platform web
*/
overflow_auto: web({
overflow: 'auto',
}),

/*
* Width
Expand All @@ -68,7 +74,7 @@
* Used for the outermost components on screens, to ensure that they can fill
* the screen and extend beyond.
*/
// @ts-ignore - web only minHeight string

Check warning on line 77 in src/alf/atoms.ts

View workflow job for this annotation

GitHub Actions / Run linters 

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
util_screen_outer: [
web({
minHeight: '100vh',
Expand Down
1 change: 1 addition & 0 deletions src/components/Menu/index.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ export function Outer({
t.name === 'light' ? t.atoms.bg : t.atoms.bg_contrast_25,
t.atoms.shadow_md,
t.atoms.border_contrast_low,
a.overflow_auto,
style,
]}>
{children}
Expand Down
2 changes: 1 addition & 1 deletion src/components/forms/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export function createInput(Component: typeof TextInput) {
<>
<Component
accessibilityHint={undefined}
hitSlop={HITSLOP_20}
{...rest}
accessibilityLabel={label}
ref={refs}
Expand All @@ -242,7 +243,6 @@ export function createInput(Component: typeof TextInput) {
placeholder={placeholder || label}
placeholderTextColor={t.palette.contrast_500}
keyboardAppearance={t.name === 'light' ? 'light' : 'dark'}
hitSlop={HITSLOP_20}
style={flattened}
/>

Expand Down
4 changes: 4 additions & 0 deletions src/components/icons/Chevron.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@ export const ChevronTop_Stroke2_Corner0_Rounded = createSinglePathSVG({
export const ChevronBottom_Stroke2_Corner0_Rounded = createSinglePathSVG({
path: 'M3.293 8.293a1 1 0 0 1 1.414 0L12 15.586l7.293-7.293a1 1 0 1 1 1.414 1.414l-8 8a1 1 0 0 1-1.414 0l-8-8a1 1 0 0 1 0-1.414Z',
})

export const ChevronTopBottom_Stroke2_Corner0_Rounded = createSinglePathSVG({
path: 'M11.293 4.293a1 1 0 0 1 1.414 0l4 4a1 1 0 0 1-1.414 1.414L12 6.414 8.707 9.707a1 1 0 0 1-1.414-1.414l4-4Zm-4 10a1 1 0 0 1 1.414 0L12 17.586l3.293-3.293a1 1 0 0 1 1.414 1.414l-4 4a1 1 0 0 1-1.414 0l-4-4a1 1 0 0 1 0-1.414Z',
})
Loading
Loading