Fix convo header loading state #7603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged
estrattonbailey
approved these changes
Feb 3, 2025
| export function useConvoQuery(convo: ChatBskyConvoDefs.ConvoView) { | ||
| export function useConvoQuery( | ||
| convoId: string, | ||
| convo?: ChatBskyConvoDefs.ConvoView, |
There was a problem hiding this comment.
Did this need to become optional? initialConvo at the callsite should be defined, right, so this fn sig wouldn't necessarily need to change
There was a problem hiding this comment.
Ah yeah I can undo that. Motivation was to use it somewhere else, but since that's not needed I'll undo it
estrattonbailey
requested changes
Feb 3, 2025
arcalinea
temporarily deployed
to
samuel/precache-convo - social-app PR #7603
Render
Destroyed
estrattonbailey
approved these changes
Feb 3, 2025
estrattonbailey
added a commit
that referenced
this pull request
Feb 5, 2025
* origin/main: (100 commits) Adding webp to regex list. Added function return type for consistency with the rest of the functions (#7649) bump version (#7650) use did for userID (#7647) Upgrade RN to 0.76.6 (#7557) Update expo-blur (#7596) Fix slow Hosting Provider dialog (#7594) make convo menu lazy (#7604) Fix convo header loading state (#7603) Spring cleaning (#7640) Date input improvements (#7639) Add example account store (#7641) rm refs in render (#7589) change search cancel behaviour (#7624) reduce padding on video overlay (#7617) Typo fix (#7637) no follow self (#7606) env var tweaks (#7457) Test fix Add Danish localization (#7220) Add Swedish localization (#7232) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for seeding the Convo with placeholder data, which we can fetch from the RQ cache, so that we can skip the header skeleton state. The actual setup process of Convo is unchanged.
Before
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-27.at.06.45.05.mp4
After
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-27.at.06.44.49.mp4
Test plan
Test entering the convo in different ways, ensure the skeleton is skipped at least when entering from the chat list screen.
Check that the Convo system itself is broadly unchanged, other than allowing the convo and recipients to be defined early