Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to CI now that p4p is updated #655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OCopping
Copy link
Contributor

@OCopping OCopping commented Nov 19, 2024

I noticed Python 3.12 never got added to the CI after support for it in p4p got released.

@OCopping OCopping changed the title Re-add Python 3.12 to CI now that p4p is updated Add Python 3.12 to CI now that p4p is updated Nov 19, 2024
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're supporting 3.12 add it to the pyproject.toml too
Good work getting this over the line 🥳

@OCopping
Copy link
Contributor Author

The tests are failing because of a get_event_loop() deprecation warning/error.
From the docs:
Deprecated since version 3.12: Deprecation warning is emitted if there is no current event loop. In some future Python release this will become an error.

@coretl
Copy link
Collaborator

coretl commented Nov 19, 2024

The tests are failing because of a get_event_loop() deprecation warning/error. From the docs: Deprecated since version 3.12: Deprecation warning is emitted if there is no current event loop. In some future Python release this will become an error.

@evalott100 I think this is coming from the "detect pending tasks" fixture, would you mind taking a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants