Enh/control child name mangling #1222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably should move the doc commit to its own PR... |
tacaswell
force-pushed
the
enh/control_child_name_mangling
branch
from
7b0cdf3
to
4d4b761
Compare
coretl
reviewed
Nov 25, 2024
The Python name (via attributes) of a child device is `foo.bar.baz`, however for a number of historical reasons (allowed keys in mongo and for attribute access in Pandas data frames with columns named from the data keys in an event stream) ophyd-sync has replaced '.' with '_' in the names. This leads to ambiguity when looking at the (default) name to which component on which device the data came from as there may be `_` in the attribute names. Ophyd-async used '-' which does allow for round tripping. This makes it controllable on per-instance basis in ophyd-sync so that users can either make a different set of trade offs. xref bluesky/ophyd-async#666
tacaswell
force-pushed
the
enh/control_child_name_mangling
branch
from
9d3dc75
to
da50a9d
Compare
tacaswell
force-pushed
the
enh/control_child_name_mangling
branch
from
da50a9d
to
fb49ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python name (via attributes) of a child device is
foo.bar.baz, howeverfor a number of historical reasons (allowed keys in mongo and for attribute
access in Pandas data frames with columns named from the data keys in an event
stream) ophyd-sync has replaced '.' with '_' in the names. This leads to
ambiguity when looking at the (default) name to which component on which device
the data came from as there may be
_in the attribute names. Ophyd-asyncused '-' which does allow for round tripping.
This makes it controllable on per-instance basis in ophyd-sync so that users
can either make a different set of trade offs.
xref bluesky/ophyd-async#666