feat: tty free login #816
Merged
feat: tty free login #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielballan green and ready for a another pass |
danielballan
approved these changes
Nov 22, 2024
|
Looks good to me but let's get one more pair of eyes on this -- requested review from @genematx |
padraic-shafer
approved these changes
Nov 23, 2024
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
genematx
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #815
Adds
Hook to send password directly to authenticate. Not added to
loginsincecontext.authenticateis meant for programatic use, and we probably shouldn't encourage general users to type their password withoutgetpassprotections. Tests are added to mirror auth tests.prompt_for_reauthenticationis expected as True for the hook to function, and theCannotPrompterror is updated to reflect that. Alternatively, this could be updated to useif not prompt_for_reauthentication and password is not UNSET.Fixes
Idempotency in context manager used by tests to avoid TTY input for context manager. (It was used in all tests previously, so idempotentcy was not relevant).
Checklist