renames (deephaven#1909)

bmingles · Apr 11, 2024 · 4b2cd06 · 4b2cd06
1 parent 9acfc30
commit 4b2cd06
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/packages/components/src/spectrum/ItemContent.tsx b/packages/components/src/spectrum/ItemContent.tsx
@@ -28,9 +28,9 @@ export function ItemContent({
   tooltipOptions,
 }: ItemContentProps): JSX.Element | null {
   const {
+    checkOverflowRef,
     isOverflowing: isTextOverflowing,
-    ref: checkTextOverflowRef,
-    reset: resetIsOverflowing,
+    resetIsOverflowing,
   } = useCheckOverflowRef();
 
   const [previousContent, setPreviousContent] = useState(content);
@@ -66,7 +66,7 @@ export function ItemContent({
       isElementOfType(el, Text)
         ? cloneElement(el, {
             ...el.props,
-            ref: checkTextOverflowRef,
+            ref: checkOverflowRef,
             UNSAFE_className: cl(
               el.props.UNSAFE_className,
               stylesCommon.spectrumEllipsis
@@ -79,7 +79,7 @@ export function ItemContent({
   if (typeof content === 'string' || typeof content === 'number') {
     content = (
       <Text
-        ref={checkTextOverflowRef}
+        ref={checkOverflowRef}
         UNSAFE_className={stylesCommon.spectrumEllipsis}
       >
         {content}

diff --git a/packages/react-hooks/src/useCheckOverflowRef.ts b/packages/react-hooks/src/useCheckOverflowRef.ts
@@ -2,9 +2,11 @@ import { useCallback, useState } from 'react';
 import type { DOMRefValue } from '@react-types/shared';
 
 export interface CheckOverflowRefResult {
+  checkOverflowRef: <T extends HTMLElement>(
+    elRef: DOMRefValue<T> | null
+  ) => void;
   isOverflowing: boolean;
-  ref: <T extends HTMLElement>(elRef: DOMRefValue<T> | null) => void;
-  reset: () => void;
+  resetIsOverflowing: () => void;
 }
 
 export function useCheckOverflowRef(): CheckOverflowRefResult {
@@ -15,7 +17,7 @@ export function useCheckOverflowRef(): CheckOverflowRefResult {
    * overflowing so we know whether to render a tooltip showing the full content
    * or not.
    */
-  const ref = useCallback(
+  const checkOverflowRef = useCallback(
     <T extends HTMLElement>(elRef: DOMRefValue<T> | null) => {
       const el = elRef?.UNSAFE_getDOMNode();
 
@@ -30,14 +32,14 @@ export function useCheckOverflowRef(): CheckOverflowRefResult {
     []
   );
 
-  const reset = useCallback(() => {
+  const resetIsOverflowing = useCallback(() => {
     setIsOverflowing(false);
   }, []);
 
   return {
     isOverflowing,
-    ref,
-    reset,
+    checkOverflowRef,
+    resetIsOverflowing,
   };
 }