Cleanup (deephaven#1909)

bmingles · Apr 11, 2024 · 9f4c1fb · 9f4c1fb
1 parent 55d0fc2
commit 9f4c1fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/components/src/spectrum/ItemContent.tsx b/packages/components/src/spectrum/ItemContent.tsx
@@ -59,7 +59,7 @@ export function ItemContent({
     //   <Text>Some Label</Text>
     //   <Text slot="description">Some Description</Text>
     // </Item>
-    content = Children.map(content, (el, i) =>
+    content = Children.map(content, el =>
       isElementOfType(el, Text)
         ? cloneElement(el, {
             ...el.props,

diff --git a/packages/components/src/spectrum/ItemTooltip.tsx b/packages/components/src/spectrum/ItemTooltip.tsx
@@ -10,17 +10,19 @@ export interface ItemTooltipProps {
   options: TooltipOptions;
 }
 
+/**
+ * Tooltip for `<Item>` content.
+ */
 export function ItemTooltip({
   children,
   options,
 }: ItemTooltipProps): JSX.Element {
-  if (typeof children === 'boolean') {
-    return <Tooltip options={options}>{children}</Tooltip>;
-  }
-
   if (Array.isArray(children)) {
     return (
       <Tooltip options={options}>
+        {/* Multiple children scenarios include a `<Text>` node for the label 
+        and at least 1 of an optional icon or `<Text slot="description">` node.
+        In such cases we only show the label and description `<Text>` nodes. */}
         <Flex direction="column" alignItems="start">
           {children.filter(node => isElementOfType(node, Text))}
         </Flex>