fixes interface equality logic for the differ #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to account for situations that renamed the library of an interface without touching the entry point and hence don't lead to a public API change
devmil
requested review from
adamgic,
fwagner,
fabiomcarneiro and
klink182
as code owners
…nges_on_library_rename # Conflicts: # CHANGELOG.md
adamgic
reviewed
Feb 9, 2024
| return true; | ||
| } | ||
|
|
||
| // here the name is equal but we have different entry points. |
There was a problem hiding this comment.
Suggested change
| // here the name is equal but we have different entry points. | |
| // here the name is equal, but we have different entry points |
adamgic
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the logic that checks for interface equality in two package models to account for situations that renamed the library of an interface without touching the entry point and hence don't lead to a public API change
Type of Change
fixes #167