adds readability / writability data for fields #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and uses that information in the comparison
devmil
requested review from
adamgic,
fwagner,
fabiomcarneiro and
klink182
as code owners
…lity_and_writability_metadata_for_fields # Conflicts: # CHANGELOG.md # test/package_api_storage_test.dart
- introduce full library name for return types - adapt TypeIdentifier to consider dynamic for all utilities around nullable - TypeHierarchy: rename "canBeAssigned" to "isCompatibleReplacement" which is a way better name for what we actually want to know + introduce "isTypePassedIn" and fix the functionality of this method
…data_for_fields # Conflicts: # lib/src/model/executable_declaration.dart # lib/src/model/executable_declaration.freezed.dart # lib/src/model/field_declaration.freezed.dart
adamgic
approved these changes
Feb 9, 2024
devmil
deleted the
feature/add_readability_and_writability_metadata_for_fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds readability and writability information to the model for fields and uses that information to extract more kinds of API changes.
Fixes #119
Type of Change