fix: remove dependency_overrides from temporary pubspec.yaml #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make pub get not run into issues
devmil
requested review from
adamgic,
fwagner,
fabiomcarneiro,
klink182 and
marafelismino
as code owners
…agile add test for ffigen issue that gets fixed by this PR
adamgic
reviewed
Dec 9, 2024
| if (pubspecFile.existsSync()) { | ||
| try { | ||
| final pubSpec = PubSpec.load(directory: packagePath); | ||
| // removeAll of dependencyOverrides has an issue in the current version of pubspec_manager |
There was a problem hiding this comment.
Suggested change
| // removeAll of dependencyOverrides has an issue in the current version of pubspec_manager | |
| // removeAll of dependencyOverrides, there's an issue in the current version of pubspec_manager |
adamgic
reviewed
Dec 9, 2024
| try { | ||
| final pubSpec = PubSpec.load(directory: packagePath); | ||
| // removeAll of dependencyOverrides has an issue in the current version of pubspec_manager | ||
| // as it doesn't remove the section part of the dependency overrides and therefore are not removed |
There was a problem hiding this comment.
Suggested change
| // as it doesn't remove the section part of the dependency overrides and therefore are not removed | |
| // as it doesn't remove the section part of the dependency overrides and therefore it is not removed |
adamgic
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dart_apitool has issues with packages that contain dependency_overrides in their pubspec.yaml and are pulled from pub.
Background:
Packages from pub get downloaded to the pub cache and get copied into a temporary directory to do local adaptions and preparations.
Some packages, especially ones from a mono repository, contain dependency overrides that point to relative paths. Those paths are not valid if you look at this package in isolation and pub get run on that package copy fails as it is not able to resolve those relative path overrides.
To avoid this situation dart_apitool now removed dependency overrides on that local copy (to use the variant of dependencies that would be used transitively anyways)
Type of Change
Fixes #198