[Java] move creation of required unit test resources into separate shell script #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell script This is needed because these required resources are only created through 'docker/joynr-android/scripts/build/java-android-clean-build'. If 'java-android-clean-build' wasn't executed in the past the resources aren't available and some tests from 'java/messaging/mqtt/joynr-mqtt-client' will fail. With these changes it doesn't matter from which 'clean-build' script the maven build process was started.
…ssful status The script always exits with return code 0 to not break the maven build. Without this change, running the unit tests of 'java/messaging/mqtt/joynr-mqtt-client' outside of the joynr docker container would fail and therefore break the maven build.
The shell script 'gen-java-keystore-truststore.sh' only works correctly if it is executed inside a joynr-docker-container. On a windows system it would break the maven build, because in most cases running shell scripts isn't supported or requires additional configurations. The environment variable 'JOYNR_DOCKER_ENVIRONMENT' can be checked by maven or shell scripts to determine if it is save to do some magic which would only work inside the joynr-docker-containers.
|
PR withdrawn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #30 and #36
The maven project
java/messaging/mqtt/joynr-mqtt-clientrequires additional files during the unit tests. These files are only created throughdocker/joynr-android/scripts/build/java-android-clean-build. If this script wasn't executed in the past, the files are not available and some tests will fail. This PR moves the creation of the required files fromdocker/joynr-android/scripts/build/java-android-clean-buildinto a separate shell script.The maven project (
java/messaging/mqtt/joynr-mqtt-client) itself executes this new shell script during the maven phasegenerate-test-resourcesto ensure the files are available during the tests. With this change it doesn't matter how the unit tests are started.