Bytes literal #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes bug #3 |
aigarius
approved these changes
Jun 18, 2020
|
Hi @aigarius , thanks for approving! Can you merge them, including the 2 latest commits? With those, I can talk to the device, and I can successfully change directories. My phone refuses all requests and gives no data, but at least this bug seems to be gone. I've exercized all commands listed in the README. |
aigarius
approved these changes
Jun 22, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service_id must be written as bytes literal, according to PEP 3112
Fixes error
can't concat str to byteswhile connecting.