Reduce reconnection message spam #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aigarius
force-pushed
the
reduce_reconnect_debug_spam
branch
from
e481d16 to
8092fc8
Compare
|
recheck |
aigarius
force-pushed
the
reduce_reconnect_debug_spam
branch
from
8092fc8 to
37a33a5
Compare
When reading a DLT from a device that is offline for a while (for example during flashing), DLT would spam 3 messages every 5 seconds. Reduce this to 1 message per minute and add time information into the messages to increase their usefulness
aigarius
force-pushed
the
reduce_reconnect_debug_spam
branch
from
37a33a5 to
31ccf70
Compare
|
Please help to add unit test cases for your change. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a DLT from a device that is offline for a while (for example during flashing), DLT would spam 3 messages every 5 seconds.
Reduce this to 1 message per minute and add time information into the messages to increase their usefulness