chore: remove ChainSpecHardforks
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
rpc
branch
6 times, most recently
from
dc364b3
to
0d0a4d3
Compare
pythonberg1997
force-pushed
the
rpc
branch
2 times, most recently
from
6356173
to
669a54e
Compare
pythonberg1997
changed the title
ChainSpecHardforks
pythonberg1997
changed the title
ChainSpecHardforksChainSpecHardforks
unclezoro
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to remove
ChainSpecHardforksfrom the codebaseRationale
Previously, we implemented some BSC functionality using the nightly trait alias feature, which resulted in numerous BSC feature cfg flags in our code and required nightly Rust for compilation. We have now restructured the code to remove this feature, improving code cleanliness and readability.
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts