Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #396

Closed
wants to merge 1 commit into from
Closed

Conversation

mateuslatrova
Copy link
Contributor

@mateuslatrova mateuslatrova commented Sep 29, 2023

add "copy to clipboard icon" in installation section.

We cherrypicked PR #369 for this.

Original Pull Request: #369
Author: Muhammad-Aadil

@alan-barzilay
Copy link
Collaborator

thanks @mateuslatrova !
Can I just be nitpicky about one little thing? sorry about that haha Could you reword the commit so that in its body it has reference to the original PR and a mention of the original author? apparently when you cherry picked the commit and pushed it you became the author.

My instructions were lacking since you did exactly as I requested, I will try to figure out how to preserve authorship for future PRs but for the time being could you just reword the commit? I would like for us to be transparent about it and avoid possible open source drama haha

firilisinof pushed a commit to firilisinof/pipreqs that referenced this pull request Oct 7, 2023
- Based on PR bndr#369 and bndr#396
- Authors Muhammad-Aadil and mateuslatrova
alan-barzilay pushed a commit that referenced this pull request Oct 8, 2023
- Based on PR #369 and #396
- Authors Muhammad-Aadil and mateuslatrova
@alan-barzilay
Copy link
Collaborator

implemented on PR #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants